Enable Desktop Notifications
Review Request #7660 — Created Sept. 25, 2015 and submitted — Latest diff uploaded
This task created a desktop notification to send to users when an update has been made to a review request. This involved adding a JSON column to the user profile called settings to represent user settings such as their preference on recieving desktop notifications. Users can enable or disable the desktop notifications using an option in the account setting form.
Tested on Chrome, Firefox, Internet Explorer and Safari.
Test Cases
1. Notifications enabled both in permissions and in account settings, and browser supported
expected: notification is shows
2. Notifications enabled in permissions but not in account settings, and browser supported
expected: updates bubble displayed
3. Notifications disabled in permissions but enabled in account settings, and browser supported
expected: updates bubble displayed
4. Notifications not supported by browser (Internet Explorer)
expected: updates bubble displayedThe JS Unit tests were also run during the testing for this task.
reviewboard/accounts/models.py |
---|
reviewboard/accounts/forms/pages.py |
---|
reviewboard/static/rb/js/pages/views/reviewablePageView.js |
---|
reviewboard/static/rb/js/ui/managers/notificationManagerModel.js |
---|
reviewboard/static/rb/js/ui/managers/tests/notificationManagerModelTests.js |
---|