Prevent the diff viewer from styling .txt files.

Review Request #7623 — Created Sept. 13, 2015 and submitted

Information

Review Board
release-2.0.x

Reviewers

Pygments assumes that .txt files should be styled using ResourceLexer by
default, when guessing by filename. This is very often wrong, and
results in a bunch of error indicators in the style, for practically
every word in the file.

We now maintain a blacklist of filename extensions that won't be styled.
It so far just contains .txt files.

Loaded a text file in the diff viewer before the fix, and saw all the
error indicators.

Loaded a text file after the fix and saw that it looked like a plain
text file.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/chunk_generator.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/chunk_generator.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (f4a7da4)