Summary

Fix Djblets packaging on newer versions of Django.

Review Request #7622 — Created Sept. 10, 2015 and submitted Dec. 2, 2015, 11:59 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This brings over some of the other packaging fixes we have from other

projects, in order to enable the Djblets package to be built against

Django 1.7/1.8.
The primary differences are that we must now call django.setup() on

these versions, and we need to call the management command for building

localization files using the proper machinery instead of directly

importing and calling the command's internal functions.

Testing Done

Built the Djblets packages against both Django 1.6 and 1.8, without any
problems.

Issues

Description	From	Last Updated
'is_exe_in_path' imported but unused	reviewbot	Nov. 3, 2015, 5:24 p.m.
'pkg_resources' imported but unused	reviewbot	Nov. 3, 2015, 5:25 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Nov. 3, 2015, 5:25 p.m.
'pkg_resources' imported but unused	reviewbot	Nov. 3, 2015, 5:27 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Nov. 3, 2015, 5:27 p.m.

Tool: Pyflakes
Processed Files:
    contrib/internal/build-i18n.py
    contrib/internal/build-media.py



Tool: PEP8 Style Checker
Processed Files:
    contrib/internal/build-i18n.py
    contrib/internal/build-media.py

contrib/internal/build-i18n.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'is_exe_in_path' imported but unused
```
contrib/internal/build-media.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'pkg_resources' imported but unused
```
contrib/internal/build-media.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

You have a typo in your description: "to be built" instead of "to be build".

Change Summary:


Removed an unused import.

Description:

		This brings over some of the other packaging fixes we have from other
~		projects, in order to enable the Djblets package to be build against
	~	projects, in order to enable the Djblets package to be built against
		Django 1.7/1.8.

		The primary differences are that we must now call django.setup() on
		these versions, and we need to call the management command for building
		localization files using the proper machinery instead of directly
		importing and calling the command's internal functions.

Diff:

Revision 2 (+25 -8)

Show changes

	contrib/internal/build-i18n.py
	contrib/internal/build-media.py

Tool: Pyflakes
Processed Files:
    contrib/internal/build-i18n.py
    contrib/internal/build-media.py



Tool: PEP8 Style Checker
Processed Files:
    contrib/internal/build-i18n.py
    contrib/internal/build-media.py

contrib/internal/build-media.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'pkg_resources' imported but unused
```
contrib/internal/build-media.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.10.x (b466903)