Summary

Refactor email module to use Djblets EmailMessage

Review Request #7602 — Created Aug. 18, 2015 and submitted Aug. 23, 2015, 7:54 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

~~7601~~

Reviewers

Groups

reviewboard

People

Description

The reviewboard.notifications.email module has been refactored to use

the EmailMessage class provided by Djblets. Review Board subclasses

it to provide customization based off of site configuration settings.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
'EmailMultiAlternatives' imported but unused	reviewbot	Aug. 18, 2015, 6:07 p.m.
'EmailMessage' imported but unused	reviewbot	Aug. 18, 2015, 6:07 p.m.
If you don't specify a default, it should fall back to the sitewide default.	chipx86	Aug. 20, 2015, 2:40 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'EmailMultiAlternatives' imported but unused
```
reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'EmailMessage' imported but unused
```

Diff:

Revision 2 (+65 -148)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Diff:

Revision 3 (+65 -148)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Diff:

Revision 4 (+65 -147)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

reviewboard/notifications/email.py (Diff revision 4)
The issue has been resolved. Show all issues
```
If you don't specify a default, it should fall back to the sitewide default.
```

Diff:

Revision 5 (+64 -147)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.6.x (d236574)