Summary

Fix bad italic styling for code blocks in CodeMirror.

Review Request #7590 — Created Aug. 14, 2015 and submitted Aug. 14, 2015, 7:27 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

4f0111c...

Reviewers

Groups

reviewboard

People

Description

CodeMirror uses the .cm-comment class to indicated inline and fenced code

blocks, which our reviews CSS displays in italics. This change overrides that

class when inside a CodeMirror to not show italics.

Testing Done


Wrote a comment with inline and fenced code blocks. Saw that the text was no

  longer italicized in the editor.
Published a review with a code block containing a comment. Saw that comment

  was displayed in italics.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/pages/reviews.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/pages/reviews.less

<p>So ideally, comments should be italic, since they render as italic, but literals should not be. Maybe that's not possible, though... If not, this is fine, but we should make a task to look into whether we can differentiate the two.</p>

david Aug. 14, 2015, 7:15 p.m.

I looked into this already. Short of hacking up CodeMirror, I don't think we can do anything.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (f32e670)