• 
      

    Make the application shell and projects list visible when logged out.

    Review Request #7584 — Created Aug. 13, 2015 and submitted

    Information

    student-sonar
    master
    e76508e...

    Reviewers

    Now that we're expecting people to use Sonar for the projects list, we need it
    to be visible to users who aren't logged in. This change makes that possible.

    As part of this:

    • We no longer have the view which is just a big "Log in" button". Instead, we
      have a root view that shows a quick intro and has the button.
    • We now have a root view when logged in, kind of crappy as it is.
    • The projects list is now available when logged out.
    • Other views show an error if they're accessed when logged out or accessed by
      a non-admin.
    • Verified both the login link and login button.
    • Saw the different root views.
    • Tested the permission denied views.

    Description From Last Updated

    I think .forEach should be on the next line.

    brenniebrennie

    would null be a better choice?

    brenniebrennie
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          lib/frontend/application.js
          lib/frontend/header-view.js
          lib/frontend/root-view.js
          views/login.handlebars
          lib/frontend/sidebar-view.js
          lib/frontend/application-view.js
          views/main.handlebars
          lib/routes.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          lib/frontend/application.js
          lib/frontend/header-view.js
          lib/frontend/root-view.js
          views/login.handlebars
          lib/frontend/sidebar-view.js
          lib/frontend/application-view.js
          views/main.handlebars
          lib/routes.js
      
      
    2. 
        
    david
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          lib/frontend/application.js
          lib/frontend/header-view.js
          lib/frontend/root-view.js
          views/login.handlebars
          lib/frontend/sidebar-view.js
          lib/frontend/application-view.js
          views/main.handlebars
          lib/routes.js
          lib/frontend/student-projects-view.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          lib/frontend/application.js
          lib/frontend/header-view.js
          lib/frontend/root-view.js
          views/login.handlebars
          lib/frontend/sidebar-view.js
          lib/frontend/application-view.js
          views/main.handlebars
          lib/routes.js
          lib/frontend/student-projects-view.js
      
      
    2. 
        
    brennie
    1. 
        
    2. lib/frontend/sidebar-view.js (Diff revision 2)
       
       
      Show all issues

      I think .forEach should be on the next line.

    3. lib/routes.js (Diff revision 2)
       
       
      Show all issues

      would null be a better choice?

    4. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (eecd379)