Summary

Add a function for returning the best gravatar URL for the display.

Review Request #7573 — Created Aug. 7, 2015 and submitted Aug. 11, 2015, 10:38 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This splits out all the URL computation logic from $.fn.retinaGravatar()
into a new Djblets.getGravatarForDisplay(). This can be used in cases
where the HTML for a piece of UI is being generated and isn't yet part
of the DOM, and can be more efficient than post-processing existing
elements.

Testing Done

Tested that existing Gravatars were continuing to work.
Used this function in some code that was building HTML fragments. It

resulted in Retina-friendly Gravatars.

Issues

Description	From	Last Updated
There's no reason to define a variable here now.	david	Aug. 10, 2015, 2:38 p.m.

Tool: PEP8 Style Checker
Ignored Files:
    djblets/static/djblets/js/jquery.gravy.retina.js
    djblets/static/djblets/js/jquery.gravy.util.js



Tool: Pyflakes
Ignored Files:
    djblets/static/djblets/js/jquery.gravy.retina.js
    djblets/static/djblets/js/jquery.gravy.util.js

djblets/static/djblets/js/jquery.gravy.retina.js (Diff revision 1)
The issue has been dropped. Show all issues
```
There's no reason to define a variable here now.
```
1. chipx86 Aug. 10, 2015, 2:39 p.m.
  It's used in $el.attr('src').

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (434b038)