Add E-Mail Extension Hooks
Review Request #7563 — Created July 31, 2015 and submitted
E-mail extension hooks allow extensions to modify the recipients of
e-mails sent for the following events:
- review request published;
- review request closed;
- review published; and
- review reply published;
There is a specific hook for each e-mail event and a generic
EmailHook which can trigger for any of the above events.
Unit tests have been added to ensure that the hooks behave as
expected.
Documentation has been added to the manual that covers all the new
hooks.
Ran unit test.
Built the docs and viewed them.
| Description | From | Last Updated |
|---|---|---|
|
Col: 1 E302 expected 2 blank lines, found 1 |
 reviewbot
|
|
|
Col: 26 E124 closing bracket does not match visual indentation |
reviewbot
|
|
|
Col: 64 E202 whitespace before ')' |
reviewbot
|
|
|
Col: 9 W503 line break before binary operator |
reviewbot
|
|
|
This seems like something that would be great to put in djblets siteconfig module. |
 david
|
|
|
Can we include the word "extension" or "hook" in this function name somehow? |
david
|
- Change Summary:
-
PEP8
- Diff:
-
Revision 2 (+1022 -17)
-
Tool: Pyflakes Processed Files: reviewboard/notifications/email.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/review_request_published_email_hook.rst docs/manual/extending/extensions/hooks/review_request_closed_email_hook.rst docs/manual/extending/extensions/hooks/email-hook.rst docs/manual/extending/extensions/hooks/index.rst docs/manual/extending/extensions/hooks/review_published_email_hook.rst docs/manual/extending/extensions/hooks/review_reply_published_email_hook.rst Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/email.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/review_request_published_email_hook.rst docs/manual/extending/extensions/hooks/review_request_closed_email_hook.rst docs/manual/extending/extensions/hooks/email-hook.rst docs/manual/extending/extensions/hooks/index.rst docs/manual/extending/extensions/hooks/review_published_email_hook.rst docs/manual/extending/extensions/hooks/review_reply_published_email_hook.rst
- Diff:
-
Revision 3 (+1016 -17)
-
Tool: Pyflakes Processed Files: reviewboard/notifications/email.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/review_request_published_email_hook.rst docs/manual/extending/extensions/hooks/review_request_closed_email_hook.rst docs/manual/extending/extensions/hooks/email-hook.rst docs/manual/extending/extensions/hooks/index.rst docs/manual/extending/extensions/hooks/review_published_email_hook.rst docs/manual/extending/extensions/hooks/review_reply_published_email_hook.rst Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/email.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/review_request_published_email_hook.rst docs/manual/extending/extensions/hooks/review_request_closed_email_hook.rst docs/manual/extending/extensions/hooks/email-hook.rst docs/manual/extending/extensions/hooks/index.rst docs/manual/extending/extensions/hooks/review_published_email_hook.rst docs/manual/extending/extensions/hooks/review_reply_published_email_hook.rst
Tool: Pyflakes Processed Files: reviewboard/notifications/email.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/review_request_published_email_hook.rst docs/manual/extending/extensions/hooks/review_request_closed_email_hook.rst docs/manual/extending/extensions/hooks/email-hook.rst docs/manual/extending/extensions/hooks/index.rst docs/manual/extending/extensions/hooks/review_published_email_hook.rst docs/manual/extending/extensions/hooks/review_reply_published_email_hook.rst Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/email.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/review_request_published_email_hook.rst docs/manual/extending/extensions/hooks/review_request_closed_email_hook.rst docs/manual/extending/extensions/hooks/email-hook.rst docs/manual/extending/extensions/hooks/index.rst docs/manual/extending/extensions/hooks/review_published_email_hook.rst docs/manual/extending/extensions/hooks/review_reply_published_email_hook.rst