Summary

Fix UnicodeDecodeErrors when sending e-mails with utf-8 contents.

Review Request #7553 — Created July 28, 2015 and submitted July 28, 2015, 3:29 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3926

Depends On

Commit

4ee41aa...

Reviewers

Groups

reviewboard

People

Description

When a review request e-mail had utf-8 in the body, it would fail to send
because of a UnicodeDecodeError while assembling the data that gets sent to the
server. The fix is a pretty trivial addition of some .encode() calls.

We hadn't caught this before because the test backend for e-mail in django
doesn't run through the same sort of internal processing as other backends do.
I've changed an existing test case and added a new one so that we use the
console e-mail backend while running the unicode tests, so that we exercise the
same machinery.

Testing Done

Ran unit tests. Before the encode changes, they failed. After, they succeed.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	July 28, 2015, 11:17 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	July 28, 2015, 11:17 a.m.
Would this maybe be a useful thing to turn into a context manager that other future tests could use?	brennie	July 28, 2015, 1:27 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Change Summary:

pep8

Commit:

fe7be8309409d00bb4f7875d6141db8da6b10c9f

da910ad393b61ae6bc1cb7d48edaaa747b397891

Diff:

Revision 2 (+47 -19)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Ship it!

reviewboard/notifications/tests.py (Diff revision 2)

The issue has been resolved. Show all issues

Would this maybe be a useful thing to turn into a context manager that other future tests could use?

Change Summary:

Implement settings change as a context manager.

Commit:

da910ad393b61ae6bc1cb7d48edaaa747b397891

4ee41aac5b8915e43adf630350efca615836bb18

Diff:

Revision 3 (+51 -19)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Status:: Completed
Change Summary:: Pushed to release-2.0.x (a9819cb)