Fix a UnicodeDecodeError in normalizing CVS keywords.

Review Request #7552 — Created July 28, 2015 and submitted

Information

Review Board
release-2.0.x
06c2d64...

Reviewers

The code to find and replace keywords in diffs for CVS was using a unicode
regex when it needed a byte regex. This change fixes that.

New unit test failed before the fix, succeeds after it.

Description From Last Updated

Single quotes?

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/cvs.py
        reviewboard/scmtools/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/cvs.py
        reviewboard/scmtools/tests.py
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/scmtools/tests.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Single quotes?

  3. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (3977b23)