Summary

Fix a UnicodeDecodeError in normalizing CVS keywords.

Review Request #7552 — Created July 28, 2015 and submitted July 28, 2015, 8:19 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3931

Depends On

Commit

06c2d64...

Reviewers

Groups

reviewboard

People

Description

The code to find and replace keywords in diffs for CVS was using a unicode
regex when it needed a byte regex. This change fixes that.

Testing Done

New unit test failed before the fix, succeeds after it.

Issues

Description	From	Last Updated
Single quotes?	brennie	July 28, 2015, 8:18 p.m.

Expand All
Collapse All

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/tests.py

Ship it!

reviewboard/scmtools/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Single quotes?

Status:: Completed
Change Summary:: Pushed to release-2.0.x (3977b23)