Fix the spacing above tabs in the text review UIs with tabs.

Review Request #7547 — Created July 25, 2015 and submitted

Information

Review Board
release-2.5.x

Reviewers

The text review UI pages containing tabs (like the Markdown page) had an
ugly gap between the review request action bar and the rest of the box.
This was due to how a margin for the tabs was interacting with other
elements on the page. Switching that margin to being a padding fixes
this.

When not using tabs, the header was clashing a bit with the tab color,
making for a bad transition. In this case, we now keep the standard
header color.

Tested a variety of file attachments. The text-based ones looked
conssitent within their type of file now, and there was no ugly
gap.


reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/pages/text-review-ui.less
        reviewboard/templates/reviews/ui/text.html
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/pages/text-review-ui.less
        reviewboard/templates/reviews/ui/text.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (c89c519)