Attempt to standardize syntax styles between Pygments and CodeMirorr.

Review Request #7542 — Created July 25, 2015 and submitted

Information

Review Board
release-2.5.x

Reviewers

Syntax highlighting appeared very differently between Pygments and
CodeMirror, with the latter using its default theme. While a nice
default, it sharply changed when saving the text.

We now have a greater degree of consistency between the two. It is
definitely not perfect, as the two have different ideas as to the
granularity they should use for determining style types, and some simply
conflict.

Still, this is a lot better than what we had, and the differences are
minor enough. CodeMirror now mostly follows what we're using for
Pygments.

Tested a bunch of code from different languages and compared the results.
Things looked nearly identical, with some exceptions (such as True in
Python, which we can't make the same without messing up other things).

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/ui/views/textEditorView.js
        reviewboard/static/rb/css/syntax.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/ui/views/textEditorView.js
        reviewboard/static/rb/css/syntax.less
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (5b60595)