• 
      

    Opening and closing rich text editors no longer creates drafts

    Review Request #7539 — Created July 24, 2015 and submitted

    Information

    Review Board
    release-2.0.x

    Reviewers

    Previously, opening and closing a Markdown editor would mark the field
    as dirty and, in the case of the review request editor, would create a
    new review request draft. The reason this occurs is that CodeMirror's
    isClean does not work the way we want (or it lies), so we check for
    dirtiness ourselves by comparing the initial value with CodeMirror's
    reported value.

    Ran JS tests.

    Verified that editing either the text or the "Enable Markdown" setting
    creates a draft while just opening and closing the editor does not.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/ui/views/textEditorView.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/ui/views/textEditorView.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (65d8b75)