Summary

Fix UnicodeDecodeError when parsing SVN diffs with accents

Review Request #7535 — Created July 22, 2015 and submitted July 22, 2015, 4:35 p.m. — Latest diff uploaded July 22, 2015, 6:59 a.m.

Information

Owner

mabes

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In ReviewBoard 2.0.x, uploading a SVN diff from a french-localized SVN yields a Unicode error when parsing the diff headers. French SVN diff have accents in them :

Index: www/app/design/frontend/mobile/default/layout/page.xml
===================================================================
--- www/app/design/frontend/mobile/default/layout/page.xml  (révision 20613)
+++ www/app/design/frontend/mobile/default/layout/page.xml  (copie de travail)


This causes the following error when uploading such a diff :
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 22: ordinal not in range(128)


This patches fixes the issue by forcing a binary comparison, like the parse_diff_header function does.

Testing Done

This patch fixed the bug on my RB site