Summary

Make another attempt at fixing packaging.

Review Request #7529 — Created July 17, 2015 and submitted July 20, 2015, 1:27 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The prior attempt at fixing packaging appeared to work, but was due to

some stale generated files that ended up in an include path. This fixes

the packaging properly.
STATIC_ROOT wasn't actually meshing well with the include path. The

include path now points to the static/ directory instead of

static/djblets/, and STATIC_ROOT now expands to an empty string. This

allows an import like @{STATIC_ROOT}/djblets/ to match djblets/

within Djblets's static/ directory.
This also means that, while we can safely use STATIC_ROOT for imports,

we cannot use it for anything that will expand within the .css output

(such as image URLs).

Testing Done

Started from a completely fresh environment, and generated a suitable
package.

Tool: PEP8 Style Checker
Processed Files:
    contrib/internal/conf/settings_local.py

Ignored Files:
    reviewboard/static/rb/css/pages/reviews.less



Tool: Pyflakes
Processed Files:
    contrib/internal/conf/settings_local.py

Ignored Files:
    reviewboard/static/rb/css/pages/reviews.less

```
Typo in your description.
```

Description:: The prior attempt at fixing packaging appeared to work, but was due to
some stale generated files that ended up in an include path. This fixes
the packaging properly.

STATIC_ROOT wasn't actually meshing well with the include path. The
include path now points to the static/ directory instead of
static/djblets/, and STATIC_ROOT now expands to an empty string. This
allows an import like @{STATIC_ROOT}/djblets/ to match djblets/
within Djblets's static/ directory.

This also means that, while we can safely use STATIC_ROOT for imports,
~ we cnanot use it for anything that will expand within the .css output
~ we cannot use it for anything that will expand within the .css output
(such as image URLs).

Ship it!

```
Ship It!
```

Status:: Completed

		The prior attempt at fixing packaging appeared to work, but was due to
		some stale generated files that ended up in an include path. This fixes
		the packaging properly.

		`STATIC_ROOT` wasn't actually meshing well with the include path. The
		include path now points to the `static/` directory instead of
		`static/djblets/`, and `STATIC_ROOT` now expands to an empty string. This
		allows an import like `@{STATIC_ROOT}/djblets/` to match `djblets/`
		within Djblets's `static/` directory.

		This also means that, while we can safely use `STATIC_ROOT` for imports,
~		we cnanot use it for anything that will expand within the .css output
	~	we cannot use it for anything that will expand within the .css output
		(such as image URLs).