• 
      

    Fix importing .less files from Djblets during packaging.

    Review Request #7528 — Created July 16, 2015 and submitted

    Information

    Review Board
    release-2.5.x

    Reviewers

    Building a package was failing due to reviews.less attempting to
    reference a Djblets .less file. This wasn't working for two reasons.

    First, STATIC_ROOT was undefined during packaging, preventing this path
    from working at all.

    Second, Djblets's static media files were not in the include path,
    making it impossible for the referenced files to be found during
    packaging.

    To fix this, our static media builder script now defines some arguments
    to pass to lessc that set the include path and provides some global
    variables. This is similar to what's set for packaged extensions, though
    is a subset of only the data needed by Review Board's own .less files.

    Successfully built a package.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          contrib/internal/conf/settings_local.py
      
      Ignored Files:
          reviewboard/static/rb/css/pages/reviews.less
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          contrib/internal/conf/settings_local.py
      
      Ignored Files:
          reviewboard/static/rb/css/pages/reviews.less
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (8186d9b)