Polish the style of the comment dialog.

Review Request #7461 — Created June 26, 2015 and submitted

Information

Review Board
release-2.5.x
19496d4...

Reviewers

The comment dialog was looking pretty old, with its black borders and
square corners. It was also a bit annoying that the text field would
shrink when showing the dirty state message.

This tweaks the style a bit, making the dialog a bit softer, with
rounded corners and lighter borders. It's also a bit larger, giving more
room for comment entry.

The status message is gone, preventing that jump. Instead, an
"(unsaved)" label appears on the dialog header.

The "Other reviews" hasn't really been changed any. It's still the same
sorta ugly box it was before, with the exception being that the View and
Reply actions are no longer ugly black-outlined boxes. They're now
simple links. This box will need its own restyle/redesign at some point.

Played with the dialog, resized it, entered text, viewed comments.
Everything looked and acted as expected.

Unit tests pass.


Description From Last Updated

This would be a lot smaller if you skipped the variable and just had two calls to .text() inside the …

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/models/commentEditorModel.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/models/commentEditorModel.js
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/static/rb/js/views/commentDialogView.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    Show all issues

    This would be a lot smaller if you skipped the variable and just had two calls to .text() inside the conditional.

  3. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/models/commentEditorModel.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/models/commentEditorModel.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (ffb69d5)