• 
      

    Fix a couple regressions in the new chunk highlighter.

    Review Request #7460 — Created June 26, 2015 and submitted

    Information

    Review Board
    release-2.5.x
    e3a3d5c...

    Reviewers

    The new chunk highlighter had two regressions. First, if the width of
    the page shrunk, there would be a horizontal scrollbar, due to the
    highlighter width not being reset to the natural width of the container.
    
    Second, the code assumed that there were chunks to display, but for
    loading diffs, this wouldn't be the case. We now check to make sure we
    can get the position of the chunk before doing any calculations based
    off of it, mirroring the logic we had before.

    No longer hit JavaScript errors due to pending diff loads.

    Resized the window back and forth, and saw that the highlighter width
    was correct.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/diffviewer/views/chunkHighlighterView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/diffviewer/views/chunkHighlighterView.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (d72c73a)