Summary

Provide a sane error if encountering multiple conflicting repositories.

Review Request #7459 — Created June 26, 2015 and submitted June 26, 2015, 4:38 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

7f1f601...

Reviewers

Groups

reviewboard

People

Description

If two repositories conflict (one has a Mirror Path matching the Path of
another repository), then validating a diff or creating a review request
in the API will result in an HTTP 500 error, due to a
MultipleObjectsReturned exception.

We now check for this and provide a more reasonable error message
instead, with a suggestion for how to resolve the issue.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
I thought we were moving away from doing IO in tests just to read data?	brennie	June 26, 2015, 11:31 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/tests/test_review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/tests/test_review_request.py

reviewboard/webapi/tests/test_validate_diff.py (Diff revision 1)

The issue has been resolved. Show all issues

I thought we were moving away from doing IO in tests just to read data?

chipx86 June 26, 2015, 11:35 a.m.

Generally, yes, but not in all cases. In this one, it's worth going that direction, though given that the other tests are all using the same data, I was tempted just to have them all transition over in the same change.

Some other changes, like ones that need a binary file for testing (trophy.png), will likely continue to do disk IO. We also do IO for fixtures.

Change Summary:

Removed the disk IO from the new unit test.

Commit:

9709917a431aca066d040aa3aa9f66b876b22cbb

7f1f6017629ce97bd79b704b817d1f626cc03fa0

Diff:

Revision 2 (+81 -2)

Show changes

	reviewboard/webapi/resources/review_request.py
	reviewboard/webapi/resources/validate_diff.py
	reviewboard/webapi/tests/test_review_request.py
	reviewboard/webapi/tests/test_validate_diff.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/tests/test_review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/tests/test_review_request.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (8fd58f2)