Fish Trophy

brennie got a fish trophy!

Fish Trophy

Allow for trivial review reply publishes

Review Request #7447 — Created June 23, 2015 and submitted

Information

Review Board
release-2.5.x
f638708...

Reviewers

Trivial review replies can be published, that is, published without
sending an e-mail notification.

This patch also fixes up some of the semantics in the review request
publishing. The not-trivial id has been changed to a send-email
class as it makes a bit more semantic sense.

NB: This is heavily based on Jessica Qian's work in
https://reviews.reviewboard.org/r/7125/

Ran unit tests. Ran JS tests.

Tested both review reply and review request publishing with and without
the "Send E-Mail" box checked. It works as expected.

Tested that the "Send E-Mail" checkboxes do not appear when e-mails are
disabled for the server.

Description From Last Updated

This should default to False rather than None

daviddavid

See my other comment about this in the review request banner.

daviddavid

Doesn't this change make it so you can't click the text to change the checkbox anymore?

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/email.py
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/reviews/models/review.py
        reviewboard/webapi/resources/review_reply.py
        reviewboard/reviews/signals.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/email.py
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/reviews/models/review.py
        reviewboard/webapi/resources/review_reply.py
        reviewboard/reviews/signals.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
  2. 
      
brennie
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/reviews/models/review.py
        reviewboard/notifications/email.py
        reviewboard/reviews/signals.py
        reviewboard/webapi/resources/review_reply.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/reviews/models/review.py
        reviewboard/notifications/email.py
        reviewboard/reviews/signals.py
        reviewboard/webapi/resources/review_reply.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/reviews/models/review.py
        reviewboard/notifications/email.py
        reviewboard/reviews/signals.py
        reviewboard/webapi/resources/review_reply.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/reviews/models/review.py
        reviewboard/notifications/email.py
        reviewboard/reviews/signals.py
        reviewboard/webapi/resources/review_reply.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
  2. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/reviews/models/review.py
        reviewboard/notifications/email.py
        reviewboard/reviews/signals.py
        reviewboard/webapi/resources/review_reply.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/reviews/models/review.py
        reviewboard/notifications/email.py
        reviewboard/reviews/signals.py
        reviewboard/webapi/resources/review_reply.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 4)
     
     
    Show all issues

    This should default to False rather than None

  3. Show all issues

    See my other comment about this in the review request banner.

  4. Show all issues

    Doesn't this change make it so you can't click the text to change the checkbox anymore?

    1. If you nest a an <input> inside a <label>, all text inside the <label> will focus/toggle the <input>.

  5. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/reviews/models/review.py
        reviewboard/notifications/email.py
        reviewboard/reviews/signals.py
        reviewboard/webapi/resources/review_reply.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/reviews/models/review.py
        reviewboard/notifications/email.py
        reviewboard/reviews/signals.py
        reviewboard/webapi/resources/review_reply.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/reviewable_page_data.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (88d8d33)