Fix the New Review Request page with missing commit data.
Review Request #7446 — Created June 22, 2015 and submitted
The New Review Request page's commit list was expecting a valid date for
each commit, and crashed if one wasn't provided. This would occur if dealing
with an inaccessible commit on Subversion.We now set a flag if the commit is inaccessible, and change our presentation
for that commit. The commit will say "Revision XYZ (not accessible on this
repository)", and won't be available to post for review.
Hard-coded all the data for a commit to being blank, and tried viewing the
commit list. Saw that the data, while useless, didn't look flat-out broken.Tried posting inaccessible commits for review, and couldn't. I could still
post accessible commits.
| Description | From | Last Updated |
|---|---|---|
|
Should this be gettext-ed? |
 brennie
|
- Change Summary:
-
Gettextized some text.
- Commit:
-
d58a7bfa60063a8aeb036a013bdb317f0bc73c774088ce5fce2450ea18bc45fe69ce5399ac50a395
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/resources/models/repositoryCommitModel.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/resources/models/repositoryCommitModel.js
- Change Summary:
-
- Inaccessible commits now appear greyed out and say "Revision XYZ (not accessible on this repository)".
- They also can no longer be posted for review, and do not show links to an associated review request.
- Description:
-
The New Review Request page's commit list was expecting a valid date for
~ each commit, and crashed if one wasn't provided. We now check for this, ~ and provide a different string for the template if missing. ~ each commit, and crashed if one wasn't provided. This would occur if dealing ~ with an inaccessible commit on Subversion. ~ We also now change the author name to "<unknown>" if it's blank,
~ providing at least something better than a "Revision 123 by ." ~ We now set a flag if the commit is inaccessible, and change our presentation
~ for that commit. The commit will say "Revision XYZ (not accessible on this + repository)", and won't be available to post for review. - Testing Done:
-
Hard-coded all the data for a commit to being blank, and tried viewing the
commit list. Saw that the data, while useless, didn't look flat-out broken. + + Tried posting inaccessible commits for review, and couldn't. I could still
+ post accessible commits. - Commit:
-
4088ce5fce2450ea18bc45fe69ce5399ac50a3955a6d8638493e9cd9811dc107f07f5ff9a294542e
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/css/newReviewRequest.less reviewboard/static/rb/js/resources/models/repositoryCommitModel.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/css/newReviewRequest.less reviewboard/static/rb/js/resources/models/repositoryCommitModel.js
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/resources/models/repositoryCommitModel.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/resources/models/repositoryCommitModel.js