• 
      

    Don't crash on SVN commits that are missing a date.

    Review Request #7445 — Created June 23, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    e2a29db...

    Reviewers

    It's valid for SVN commits not to have a date, and this will definitely
    happen if ACLs prevent a user from accessing the commits. We now
    properly handle the case where the date is missing, returning the commit
    with whatever info we have.
    
    This can result in a bunch of empty-looking commit entries in the New
    Review Request page, but that's better than the current behavior of
    crashing. We have no way to search for accessible commits, and it's too
    expensive to try to keep searching for accessible commits, so this is
    the best compromise we have for now.

    Unit tests pass.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/scmtools/tests.py
          reviewboard/scmtools/svn/__init__.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (ee8bb1a)