Patch for issue 3895: UnicodeDecodeError
Review Request #7442 — Created June 22, 2015 and discarded
Fix issue 3895, set encoding to prevent potential UnicodeDecodeErrors
After this patch I was able to successfully post a review that contains unicode symbol when having empty files in the patch. I haven't run the test suite (sorry don't have the time to set everything up).
Description | From | Last Updated |
---|---|---|
You can just remove results_unicode=False and it will have the same effect as decoding. |
brennie | |
Col: 80 E501 line too long (95 > 79 characters) |
reviewbot | |
results_unicode defaults to True. |
brennie | |
This isn't a correct fix (it will regress posting changes with non-utf8 files). |
david | |
Instead, we should change it so that what we're appending here are bytestrings rather than unicode objects. |
david | |
And here. |
david |
- Testing Done:
-
+ After this patch I was able to successfully post a review that contains unicode symbol when having empty files in the patch. I haven't run the test suite (sorry don't have the time to set everything up).
- Bugs:
-
- Diff:
Revision 2 (+1 -1)
-
Tool: Pyflakes Processed Files: rbtools/clients/mercurial.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/mercurial.py