• 
      

    Add some structure to the comment dialog for extensibility.

    Review Request #7441 — Created June 19, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    2627d6e...

    Reviewers

    The comment dialog's layout and structure was built for the existing set
    of checkboxes and other UI, but with no flexibility for laying out
    additional elements. One of the big problems is that, to properly size
    the text field, we needed to account for the buttons and other content
    below it, but this was hard-coding the checkboxes.
    
    Now, the dialog has been structured for a header, body area, optional
    widgets (which we can later allow extensions to add to), status, and
    buttons. The layout code takes these main areas into account, rather
    than the individual components.

    Tested in Chrome and Firefox, with the following tests:

    • Default state for a new comment.
    • Defautl state for an existing comment.
    • Default state for a comment with other comments shown on the side.
    • Toggling the dirty state with the message shown.
    • Toggling the Markdown mode with the link visibility.
    • Resizing under these different cases.
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/css/reviews.less
          reviewboard/static/rb/css/defs.less
          reviewboard/static/rb/js/views/commentDialogView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/css/reviews.less
          reviewboard/static/rb/css/defs.less
          reviewboard/static/rb/js/views/commentDialogView.js
      
      
    2. 
        
    david
    1. <p>One problem with the current implementation (at least on 2.5.x) is that when you start typing, the status line shows up, but it shows up under the buttons. Can you test that that's fixed with this?</p>

    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (77e27a9)