Summary

Fix diff submission for p4

Review Request #7439 — Created June 19, 2015 and submitted June 19, 2015, 7:51 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

3887

Depends On

Commit

2f53fc3...

Reviewers

Groups

reviewboard

People

Description

Not all SCMTools (namely Perforce) will have new revision information
for files stored in File.newInfo. In Perforce, this is actually a
timestamp so attempting to parse it as a revision will fail.

Testing Done

Ran unit tests.

Able to submit a P4 diff.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/managers.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/managers.py

Commit:

b3ca51cc7e985326221337b7a32486701bd4326d

2f53fc3048f7a46add81b4b1ed9f44f05602cb35

Diff:

Revision 2 (+1 -8)

Show changes

reviewboard/diffviewer/managers.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/managers.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/managers.py

Typo in your summary: "attmpeting"

What impact will this change have on other features?

brennie June 19, 2015, 3:51 p.m.

This shouldn't have any impact on other features. It reverts the handling for filediff dest detail to the way it was before 8c15f47ab2f29b91e3fc4ef4b62df813543bc750 .

Description:: ~
Not all SCMTOols (namely Perforce) will have new revision information for files stored in File.newInfo. In Perforce, this is actually a timestamp so attmpeting to parse it as a revision will fail.
~
Not all SCMTools (namely Perforce) will have new revision information
+ for files stored in File.newInfo. In Perforce, this is actually a
+ timestamp so attmepting to parse it as a revision will fail.

Change Summary:: I can spell, I promise :)
Description:: Not all SCMTools (namely Perforce) will have new revision information
for files stored in File.newInfo. In Perforce, this is actually a
~ timestamp so attmepting to parse it as a revision will fail.
~ timestamp so attempting to parse it as a revision will fail.

Ship it!

```
Ship it, pending the "attmepting"
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (cb9a791)

~		Not all SCMTOols (namely Perforce) will have new revision information for files stored in `File.newInfo`. In Perforce, this is actually a timestamp so attmpeting to parse it as a revision will fail.
	~	Not all SCMTools (namely Perforce) will have new revision information
	+	for files stored in `File.newInfo`. In Perforce, this is actually a
	+	timestamp so attmepting to parse it as a revision will fail.