Fix diff submission for p4
Review Request #7439 — Created June 19, 2015 and submitted
Not all SCMTools (namely Perforce) will have new revision information
for files stored inFile.newInfo. In Perforce, this is actually a
timestamp so attempting to parse it as a revision will fail.
Ran unit tests.
Able to submit a P4 diff.
- Commit:
-
b3ca51cc7e985326221337b7a32486701bd4326d2f53fc3048f7a46add81b4b1ed9f44f05602cb35
- Diff:
-
Revision 2 (+1 -8)
-
Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/managers.py Tool: Pyflakes Processed Files: reviewboard/diffviewer/managers.py
- Description:
-
~ Not all SCMTOols (namely Perforce) will have new revision information for files stored in
File.newInfo. In Perforce, this is actually a timestamp so attmpeting to parse it as a revision will fail.~ Not all SCMTools (namely Perforce) will have new revision information
+ for files stored in File.newInfo. In Perforce, this is actually a+ timestamp so attmepting to parse it as a revision will fail.
- Change Summary:
-
I can spell, I promise :)
- Description:
-
Not all SCMTools (namely Perforce) will have new revision information
for files stored in File.newInfo. In Perforce, this is actually a~ timestamp so attmepting to parse it as a revision will fail. ~ timestamp so attempting to parse it as a revision will fail.
Tool: Pyflakes Processed Files: reviewboard/diffviewer/managers.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/managers.py