Summary

Expose extra data API through new attribute

Review Request #7433 — Created June 17, 2015 and submitted June 19, 2015, 7:52 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

6ab143d...

Reviewers

Groups

reviewboard

People

Description

This patch returns each resource's extraData model attribute to be a
plain JavaScript object. The new extra data API (via RB.ExtraData) is
exposed through model.extraData instead of
model.attributes.extraData. This will prevent extensions that use the
old API from breaking but still expose the new API. JS tests have been
updated to reflect these changes.

Testing Done

Ran JS tests.
Tested with the rbstopwatch extension. It worked with this patch
applied.

Issues

Description	From	Last Updated
Can you add a doc comment?	chipx86	June 17, 2015, 9:13 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/models/commentEditorModel.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/models/tests/extraDataTests.js
    reviewboard/static/rb/js/models/extraDataMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/models/commentEditorModel.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/models/tests/extraDataTests.js
    reviewboard/static/rb/js/models/extraDataMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js

reviewboard/static/rb/js/models/extraDataMixin.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a doc comment?
```

Change Summary:

Add some documentation.

Commit:

7c209d81501eaaf297bae08c7279f2f3de5feeca

d02cb5515f9b36567f928de4d35dc4f7a54cfae7

Diff:

Revision 2 (+105 -89)

Show changes

	reviewboard/static/rb/js/models/commentEditorModel.js
	reviewboard/static/rb/js/models/extraDataMixin.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
	reviewboard/static/rb/js/models/tests/extraDataTests.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
	reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/models/commentEditorModel.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/models/tests/extraDataTests.js
    reviewboard/static/rb/js/models/extraDataMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/models/commentEditorModel.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/models/tests/extraDataTests.js
    reviewboard/static/rb/js/models/extraDataMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js

Can you test with an extension that uses the old APIs?

Change Summary:

Greatly simplify set. Fix so tests and extensions work.

Testing Done:

~		Ran JS tests.
	~	Ran JS tests.
	+	Tested with the rbstopwatch extension. It worked with this patch
	+	applied.

Commit:

d02cb5515f9b36567f928de4d35dc4f7a54cfae7

6ab143dcc06a7e231a188a609d72f7927039e737

Diff:

Revision 3 (+110 -96)

Show changes

	reviewboard/static/rb/js/models/commentEditorModel.js
	reviewboard/static/rb/js/models/extraDataMixin.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
	reviewboard/static/rb/js/models/tests/extraDataTests.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
	reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/models/commentEditorModel.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/models/tests/extraDataTests.js
    reviewboard/static/rb/js/models/extraDataMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/models/commentEditorModel.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/models/tests/extraDataTests.js
    reviewboard/static/rb/js/models/extraDataMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (236e954)