Summary

Fix all known remaining compatibility issues with Django 1.7+.

Review Request #7423 — Created June 13, 2015 and submitted June 17, 2015, 4:02 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Commit

b468dd4...

Reviewers

Groups

djblets

People

Description

This updates djblets.cache, djblets.datagrid, and djblets.gravatar to be
compatible with newer versions of Django. These include pulling in some
backwards-compatibility functions and updating to use the proper APIs.

In the case of datagrids, the profile-related code has finally been
removed. I've changed the logic to no longer assume the existence of
User.get_profile(), and instead to allow subclasses to override a
function that returns some object (a profile model, or something else)
for use in data storage.

Testing Done

All unit tests pass on Django 1.6 and 1.8.

Issues

Description	From	Last Updated
'gravatar' imported but unused	reviewbot	June 13, 2015, 2:36 a.m.
Col: 1 E302 expected 2 blank lines, found 0	reviewbot	June 13, 2015, 2:36 a.m.
undefined name 'InvalidCacheBackendError'	reviewbot	June 13, 2015, 2:37 a.m.
undefined name 'InvalidCacheBackendError'	reviewbot	June 13, 2015, 2:37 a.m.
undefined name 'parse_qsl'	reviewbot	June 13, 2015, 2:37 a.m.
Col: 42 E226 missing whitespace around arithmetic operator	reviewbot	June 13, 2015, 2:38 a.m.
This will now fail if profile is None.	david	June 16, 2015, 2:04 a.m.
This docstring isn't in the right format.	david	June 16, 2015, 2:04 a.m.
Single quotes.	david	June 16, 2015, 2:04 a.m.
Single quotes.	david	June 16, 2015, 2:04 a.m.
from __future__ import unicode_literals	brennie	June 16, 2015, 5:13 p.m.
Can you expand this to say where it comes from? Also this should probably include django's LICENSE.	david	June 17, 2015, 3:56 p.m.
Docstring formatting.	brennie	June 16, 2015, 5:13 p.m.
single quotes.	brennie	June 16, 2015, 5:13 p.m.
blank line between these.	brennie	June 16, 2015, 5:13 p.m.
blank line between these.	brennie	June 16, 2015, 5:13 p.m.

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py
    djblets/gravatars/templatetags/tests.py
    djblets/cache/backend_compat.py
    djblets/util/compat/django/core/cache.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py
    djblets/gravatars/templatetags/tests.py
    djblets/cache/backend_compat.py
    djblets/util/compat/django/core/cache.py

djblets/gravatars/templatetags/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'gravatar' imported but unused
```
djblets/util/compat/django/core/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 0
```
djblets/util/compat/django/core/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'InvalidCacheBackendError'
```
djblets/util/compat/django/core/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'InvalidCacheBackendError'
```
djblets/util/compat/django/core/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'parse_qsl'
```
djblets/util/compat/django/core/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 42
 E226 missing whitespace around arithmetic operator
```

Change Summary:


Fixed unused imports.
Fixed missing imports.
Fixed other misc. PyFlakes warnings.

Commit:

0dcb47b6b6cd24769a9d614bcda2ceb4d25aa8b3

7071dbde2b0ec89d9a6b7e24c1676dd692d1358e

Diff:

Revision 2 (+73 -19)

Show changes

	djblets/cache/backend_compat.py
	djblets/datagrid/grids.py
	djblets/gravatars/templatetags/tests.py
	djblets/util/compat/django/core/cache.py

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py
    djblets/gravatars/templatetags/tests.py
    djblets/cache/backend_compat.py
    djblets/util/compat/django/core/cache.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py
    djblets/gravatars/templatetags/tests.py
    djblets/cache/backend_compat.py
    djblets/util/compat/django/core/cache.py

djblets/datagrid/grids.py (Diff revision 2)

The issue has been resolved. Show all issues

This will now fail if profile is None.

djblets/util/compat/django/core/cache.py (Diff revision 2)

The issue has been dropped. Show all issues

This docstring isn't in the right format.

chipx86 June 16, 2015, 2:04 a.m.

It's upstream from Django. I want to minimize what we touch there, to keep it easy to diff/update when we need to.

djblets/util/compat/django/core/cache.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Single quotes.
```
1. chipx86 June 16, 2015, 2:04 a.m.
  Same.
djblets/util/compat/django/core/cache.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Single quotes.
```
1. chipx86 June 16, 2015, 2:04 a.m.
  Same.

Change Summary:

Fixed the datagrid when there's no profile.

Commit:

7071dbde2b0ec89d9a6b7e24c1676dd692d1358e

1846e8387ee8bacf7c6a001f246a3641f288c253

Diff:

Revision 3 (+68 -13)

Show changes

	djblets/cache/backend_compat.py
	djblets/datagrid/grids.py
	djblets/gravatars/templatetags/tests.py
	djblets/util/compat/django/core/cache.py

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py
    djblets/gravatars/templatetags/tests.py
    djblets/cache/backend_compat.py
    djblets/util/compat/django/core/cache.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py
    djblets/gravatars/templatetags/tests.py
    djblets/cache/backend_compat.py
    djblets/util/compat/django/core/cache.py

djblets/util/compat/django/core/cache.py (Diff revision 3)

The issue has been dropped. Show all issues

from __future__ import unicode_literals

chipx86 June 16, 2015, 5:13 p.m.

This file is an upstream Django file (anything in djblets.util.compat.django is upstream), so to keep behavior and content as close as possible, I'm not making any changes to this to match our codebase or to change behavior (such as forcing Unicode).

djblets/util/compat/django/core/cache.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Docstring formatting.
```
djblets/util/compat/django/core/cache.py (Diff revision 3)
The issue has been dropped. Show all issues
```
single quotes.
```
djblets/util/compat/django/core/cache.py (Diff revision 3)
The issue has been dropped. Show all issues
```
blank line between these.
```
djblets/util/compat/django/core/cache.py (Diff revision 3)
The issue has been dropped. Show all issues
```
blank line between these.
```

djblets/util/compat/django/core/cache.py (Diff revision 3)

The issue has been resolved. Show all issues

Can you expand this to say where it comes from? Also this should probably include django's LICENSE.

Change Summary:

Added copyright headers for the Django files, and added info on where they came from.

Commit:

1846e8387ee8bacf7c6a001f246a3641f288c253

b468dd4bd56902942316e301562c60f1b35399ee

Diff:

Revision 4 (+131 -13)

Show changes

	djblets/cache/backend_compat.py
	djblets/datagrid/grids.py
	djblets/gravatars/templatetags/tests.py
	djblets/util/compat/django/core/cache.py
	djblets/util/compat/django/core/files/locks.py

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py
    djblets/gravatars/templatetags/tests.py
    djblets/cache/backend_compat.py
    djblets/util/compat/django/core/cache.py
    djblets/util/compat/django/core/files/locks.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py
    djblets/gravatars/templatetags/tests.py
    djblets/cache/backend_compat.py
    djblets/util/compat/django/core/cache.py
    djblets/util/compat/django/core/files/locks.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (e9dd302)