Summary

Fix RelationCounterField on Django 1.7+.

Review Request #7422 — Created June 13, 2015 and submitted June 17, 2015, 3:58 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Commit

e81cc18...

Reviewers

Groups

djblets

People

Description

Django 1.7+ changed some variables around for relation fields, turning
parent_model into model and model into related_model. Especially
in the case of model, the meaning has changed significantly. We now
have some compatibility functions that check for the right thing when
attempting to access the proper variable. This restores test
functionality, bringing compatibility to Django 1.6 and 1.7/1.8.

Testing Done

These unit tests pass on Django 1.6 and 1.8.

Tool: Pyflakes
Processed Files:
    djblets/db/fields.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/db/fields.py

Change looks good but the formatting on your summary seems off.

Description:: Django 1.7+ changed some variables around for relation fields, turning
~ `parent_model into model and model into related_model. Especially
~ parent_model into model and model into related_model. Especially
in the case of model, the meaning has changed significantly. We now
have some compatibility functions that check for the right thing when
attempting to access the proper variable. This restores test
functionality, bringing compatibility to Django 1.6 and 1.7/1.8.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (65430a3)

		Django 1.7+ changed some variables around for relation fields, turning
~		`parent_model into `model` and `model` into `related_model`. Especially
	~	`parent_model` into `model` and `model` into `related_model`. Especially
		in the case of `model`, the meaning has changed significantly. We now
		have some compatibility functions that check for the right thing when
		attempting to access the proper variable. This restores test
		functionality, bringing compatibility to Django 1.6 and 1.7/1.8.