Summary

Fix the Djblets utils module tests on Django 1.7+.

Review Request #7421 — Created June 13, 2015 and submitted June 16, 2015, 1:57 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Commit

2543a5f...

Reviewers

Groups

djblets

People

Description

The utils module had a number of template-related tests that no longer
work in Django. We were digging into the internals, trying to construct
tags manually, instead of through a template string. Now, we're using
template strings, restoring compatibility across all versions.

There was also a docstring being executed in the django.core.files.locks
compatibility module, which we didn't want to execute. This has been
removed.

Testing Done

Utility unit tests pass on Django 1.6 and 1.8.

Issues

Description	From	Last Updated
'djblets_deco' imported but unused	reviewbot	June 13, 2015, 2:34 a.m.

Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py
    djblets/util/compat/django/core/files/locks.py



Tool: Pyflakes
Processed Files:
    djblets/util/tests.py
    djblets/util/compat/django/core/files/locks.py

djblets/util/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'djblets_deco' imported but unused
```

Change Summary:

Fixed an unused import.

Commit:

4ee2b75c47a7742e28fdfde5677ea04375974514

2543a5fa56667d2a18877c314d07ac4c44341de6

Diff:

Revision 2 (+37 -46)

Show changes

	djblets/util/tests.py
	djblets/util/compat/django/core/files/locks.py

Tool: Pyflakes
Processed Files:
    djblets/util/tests.py
    djblets/util/compat/django/core/files/locks.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py
    djblets/util/compat/django/core/files/locks.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (47c511a)

djblets/util/tests.py (Diff revision 1)