• 
      

    fix infinite loop in GitDiffParser

    Review Request #742 — Created Feb. 11, 2009 and submitted — Latest diff uploaded

    Information

    Review Board SVN (deprecated)

    Reviewers

    diffs for binary files created with "git diff --binary" caused an infite loop in GitDiffParser.
    
    Here are the first lines of such a diff:
    diff --git a/htdocs/img/waitforactivex.gif b/htdocs/img/waitforactivex.gif
    index e3d3208cc2baf78683e1fff64fc24b1aad594cf6..2ac21de2eaf15ec39ee799779764d3673492682a 100644
    GIT binary patch
    literal 4294
    zcmV;%5IOIOP)<h;3K|Lk000e1NJLTq008L#002b@0{{R3m^U#*00093P)t-sR8mse
    ...
    ...