• 
      

    Add pycrypto to setup.py

    Review Request #7413 — Created June 12, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    18560dd...

    Reviewers

    The change from https://reviews.reviewboard.org/r/7111/ resulted in
    PyCrypto being required for all deployments of ReviewBoard.
    Previously, it would have only been required if certain SCMs were in
    use (beanstalk, bitbucket, gitlab or unfuddle).
    
    However, it is now imported and used in the server initialization,
    which means we need to ensure that it is on the system.
    
    Yes, most systems will have pycrypto available already, but it's
    always better to be explicit and avoid unexpected failures.
    
     
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          setup.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          setup.py
      
      
    2. 
        
    sgallagh
    chipx86
    1. Made some small changes (alphabetical order, same minimum version some of our other stuff requires). Will get a release out ASAP (there are a few other important things in the pipeline too).

    2. 
        
    sgallagh
    Review request changed
    Status:
    Completed
    Change Summary:

    Fixed with modifications on release-2.0.x (d71917c)