Summary

Do not use both cumulative and condensed to refer to cumulative diffs

Review Request #7404 — Created June 10, 2015 and submitted June 11, 2015, 12:43 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

c371bb8...

Reviewers

Groups

reviewboard

People

Description

This patch updates the diff comment model and the diff comment resource
to use the term cumulative_diff instead of condensed_diff. The
option was named cumulative_diff in the diff chunk generator and the
diff chunk generator, so this is for consistency.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	June 10, 2015, 6:30 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/resources/review_diff_comment.py
    reviewboard/reviews/models/diff_comment.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/resources/review_diff_comment.py
    reviewboard/reviews/models/diff_comment.py

reviewboard/reviews/models/diff_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Change Summary:

PEP8

Commit:

387e8278f183cf888fdb23ea2d875e64faddcee2

c371bb82ae9142b04268dc225fb2e31f9df37c32

Diff:

Revision 2 (+27 -25)

Show changes

	reviewboard/reviews/models/diff_comment.py
	reviewboard/webapi/resources/review_diff_comment.py
	reviewboard/webapi/tests/test_review_comment.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/resources/review_diff_comment.py
    reviewboard/reviews/models/diff_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/resources/review_diff_comment.py
    reviewboard/reviews/models/diff_comment.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (7ee37e8)