This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-2.0.x (3505190)

Summary

Properly handle 404s in BitBucket API layer.

Review Request #7376 — Created June 4, 2015 and submitted 10 years ago

Information

Owner

david*

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

869e2ad...

Reviewers

Groups

reviewboard

People

Description*

We weren't translating 404 errors into FileNotFound, which could result in
uncaught exceptions when trying to detect whether files existed.

Testing Done

Ran unit tests. The newly-added test fails without the exception handling with
the reported error, and succeeds after.

Issues

Description	From	Last Updated
I don't think with_traceback is a thing in Python 2.x. I can't make it work, and it's not in anything …	chipx86	10 years ago
This should take the path and revision as arguments.	chipx86	10 years ago
There are no open issues

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/bitbucket.py



Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/bitbucket.py

reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)

The issue has been resolved. Show all issues

This should take the path and revision as arguments.

david 10 years ago

We don't have those in this context, and the get_file_exists implementation doesn't care about them.

chipx86 10 years ago

It's going to fail then. The path is a required argument.

chipx86 10 years ago

Maybe this can return some local exception, and the caller can catch it and raise the proper error with the path and revision?

Change Summary:

Plumb through path and revision in exception.

Commit:

8ffcb4f893c700138d226ac3a0cb20c5562a8b84

41766b040fe52ccb01ab6c3df64fde8f06ee1158

Diff:

Revision 2 (+12 -1)

Show changes

reviewboard/hostingsvcs/bitbucket.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/bitbucket.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/bitbucket.py

```
I think we need a unit test for this.
```

reviewboard/hostingsvcs/bitbucket.py (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

I don't think with_traceback is a thing in Python 2.x. I can't make it work, and it's not in anything but the Python 3 docs.

Testing Done:

~		Ran unit tests.
	~	Ran unit tests. The newly-added test fails without the exception handling with
	+	the reported error, and succeeds after.

Commit:

41766b040fe52ccb01ab6c3df64fde8f06ee1158

869e2addbd4ff5e4b20c196050f6b9290251cee7

Diff:

Revision 3 (+21 -2)

Show changes

	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/bitbucket.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/bitbucket.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (3505190)