Summary

Allow the API to validate extra fields for comments on condensed diffs

Review Request #7365 — Created June 2, 2015 and submitted June 2, 2015, 7:04 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

c6391b1...

Reviewers

Groups

reviewboard

People

Description

The review diff comment API can now validate the
extra_data.base_commit_id and extra_data.condensed_diff fields if
they are provided. Utility properties have been added to the
reviews.models.diff_comment.Comment model to facilitate getting and
setting the base commit ID and condensed diff status of the associated
file diff. These will be updated by JavaScript through the API so that
the correct diff will be rendered in reviews.

Unit tests have been added to verify the validation of these new API
fields.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
It would be more efficient if you changed the first test to just check truthiness instead of explicitly comparing against …	david	June 2, 2015, 7:03 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/resources/review_diff_comment.py
    reviewboard/reviews/models/diff_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/resources/review_diff_comment.py
    reviewboard/reviews/models/diff_comment.py

Ship it!

reviewboard/reviews/models/diff_comment.py (Diff revision 1)

The issue has been resolved. Show all issues

It would be more efficient if you changed the first test to just check truthiness instead of explicitly comparing against None.

Status:: Completed
Change Summary:: Pushed to dvcs (57c80d3)