This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-0.7.x (984f5e6)

Summary

Add --non-interactive to SVN command lines.

Review Request #7308 — Created May 16, 2015 and submitted 9 years, 11 months ago

Information

Owner

david*

Repository

RBTools

Branch

release-0.7.x

Bugs

3871

Depends On

Commit

af4282a...

Reviewers

Groups

rbtools

People

Description*

When the username and password are passed in to SVN, it can sometimes prompt
the user for whether or not they want to save the password permanently (and
likely make other prompts). This change adds --non-interactive to all SVN
command lines to make sure that nothing gets blocked waiting for user input.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This will end up running svn --non-interactive log --non-interactive.	brennie	9 years, 11 months ago
There are no open issues

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py

Looks fine in general. Trying to think if there are any cases where this is going to cause problems, though. Such as verification of an HTTPS certificate or SSH host fingerprint.

david 9 years, 11 months ago

Because we pipe stdin and stdout, there's really no chance of interactivity in svn commands actually being useful anyway.

Ship it!

```
One nit and then it looks good to me.
```
rbtools/clients/svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This will end up running svn --non-interactive log --non-interactive.
```

Status:: Completed
Change Summary:: Pushed to release-0.7.x (984f5e6)

rbtools/clients/svn.py (Diff revision 1)