Summary

Do not try to encode binary types as unicode

Review Request #7294 — Created May 8, 2015 and submitted May 13, 2015, 3:31 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

3dac015...

Reviewers

Groups

rbtools

People

Description

Previously, when trying to encode the form fields for a request, the
fields were always being encoded as UTF-8, even when they were a binary
type (e.g., unicode text encoded as UTF-8). This lead to encoding
errors and has been rectified.

A new unit test has been added to ensure this heaviour does not
regress.

Testing Done

Ran unit tests. The new unit test fails without the rest of this patch
applied.

Successfully used the RBClient to send requests with fields
containing string values and unicode values.

Successfully uploaded a review request that had UTF-8 characters in the
diff, summary, and description.

Issues

Description	From	Last Updated
""" on the next line.	chipx86	May 13, 2015, 3:31 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/request.py

Can you test that posting a review request with unicode in the diff and commit message still works?

brennie May 11, 2015, 3:15 p.m.
```
It still works.
```

Testing Done:

		Ran unit tests.

		Successfully used the `RBClient` to send requests with fields
		containing string values and unicode values.
	+
	+	Successfully uploaded a review request that had UTF-8 characters in the
	+	diff, summary, and description.

This particular change looks fine, but the rest of this file is still acting like we're working with Unicode. We should be using bytestrings everywhere, and never assuming any encoding for anything, I don't think.

We should probably also have unit tests added along with any changes to this, to test various encoding setups.

Change Summary:

Use bytestrings over unicode literals for writing to content.

Add a unit test.

Description:

		Previously, when trying to encode the form fields for a request, the
		fields were always being encoded as UTF-8, even when they were a binary
		type (e.g., unicode text encoded as UTF-8). This lead to encoding
		errors and has been rectified.
	+
	+	A new unit test has been added to ensure this heaviour does not
	+	regress.

Testing Done:

~		Ran unit tests.
	~	Ran unit tests. The new unit test fails without the rest of this patch
	+	applied.

		Successfully used the `RBClient` to send requests with fields
		containing string values and unicode values.

		Successfully uploaded a review request that had UTF-8 characters in the
		diff, summary, and description.

Commit:

-	a3310f5b5da21054363d984c62a6a8280f956e6b
+	3dac01519d49d1835e90d09a1daae33501d4bd57

Diff:

Revision 2 (+41 -16)

Show changes

	rbtools/api/request.py
	rbtools/api/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/api/request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/api/request.py

Ship it!

rbtools/api/tests.py (Diff revision 2)
Show all issues
```
""" on the next line.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (ccf4387)

rbtools/api/tests.py (Diff revision 2)