Summary

Allow the HTTP cache to be disabled or created in any location

Review Request #7293 — Created May 8, 2015 and submitted May 13, 2015, 1:15 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

99cf0ff...

Reviewers

Groups

rbtools

People

Description

The HTTP cache for the API can now be disabled via the
--disable-caching command line argument. It can also be moved to an
arbitrary location with --cache-location FILE or created in memory
with --in-memory-cache. This behaviour is also available to consumers
of the API via the RBClient. The allow_caching, cache_location,
and in_memory_cache key word arguments can be used for this.

Testing Done

Unit tests passed.

Ran the following commands:

rbt status --debug --disable-cache
rbt status --debug --in-memory-cache
rbt status --debug --cache-location /tmp/cache

The debugging information indicated the correct behaviour was taking
place in each instance.

Issues

Description	From	Last Updated
Col: 1 W391 blank line at end of file	reviewbot	May 8, 2015, 5:26 p.m.
Because of the magic of kwargs, you can just do: self._cache = APICache(create_db_in_memory=in_memory, db_location=cache_location)	david	May 11, 2015, 4:05 p.m.
Blank line between these.	chipx86	May 11, 2015, 7:02 p.m.
This can be: self.cache_path = db_location or self.DEFAULT_CACHE_PATH	chipx86	May 11, 2015, 7:02 p.m.
We should probably add config options for these as well.	chipx86	May 11, 2015, 7:03 p.m.
Missing a trailing period.	chipx86	May 11, 2015, 7:03 p.m.
It's going to delete whichever one is specified, right?	chipx86	May 11, 2015, 7:05 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/__init__.py
    rbtools/commands/__init__.py
    rbtools/commands/clearcache.py
    rbtools/api/transport/sync.py
    rbtools/api/cache.py
    rbtools/api/request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/__init__.py
    rbtools/commands/__init__.py
    rbtools/commands/clearcache.py
    rbtools/api/transport/sync.py
    rbtools/api/cache.py
    rbtools/api/request.py

rbtools/api/transport/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Commit:

7b0f4894b6c14e4174298f6cb4e445fbb0c7a16c

5de7fa0623c84c416f2db7ba1f3e71ffe99bdb04

Diff:

Revision 2 (+106 -43)

Show changes

	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/transport/__init__.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/clearcache.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/__init__.py
    rbtools/commands/__init__.py
    rbtools/commands/clearcache.py
    rbtools/api/transport/sync.py
    rbtools/api/cache.py
    rbtools/api/request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/__init__.py
    rbtools/commands/__init__.py
    rbtools/commands/clearcache.py
    rbtools/api/transport/sync.py
    rbtools/api/cache.py
    rbtools/api/request.py

rbtools/api/request.py (Diff revision 2)

The issue has been resolved. Show all issues

Because of the magic of kwargs, you can just do:

self._cache = APICache(create_db_in_memory=in_memory,
                       db_location=cache_location)

Commit:

5de7fa0623c84c416f2db7ba1f3e71ffe99bdb04

1594a8f787880fbf97f04a3e853bebc9dee3d37f

Diff:

Revision 3 (+104 -43)

Show changes

	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/transport/__init__.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/clearcache.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/__init__.py
    rbtools/commands/__init__.py
    rbtools/commands/clearcache.py
    rbtools/api/transport/sync.py
    rbtools/api/cache.py
    rbtools/api/request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/__init__.py
    rbtools/commands/__init__.py
    rbtools/commands/clearcache.py
    rbtools/api/transport/sync.py
    rbtools/api/cache.py
    rbtools/api/request.py

rbtools/api/cache.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Blank line between these.
```

rbtools/api/cache.py (Diff revision 3)

The issue has been resolved. Show all issues

This can be:

self.cache_path = db_location or self.DEFAULT_CACHE_PATH

rbtools/commands/__init__.py (Diff revision 3)

The issue has been resolved. Show all issues

We should probably add config options for these as well.

rbtools/commands/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing a trailing period.
```
rbtools/commands/clearcache.py (Diff revision 3)
The issue has been resolved. Show all issues
```
It's going to delete whichever one is specified, right?
```

Change Summary:

Address Christian's issues.

Commit:

1594a8f787880fbf97f04a3e853bebc9dee3d37f

99cf0ff0b1b958979ebb1d2108d2ef3a6f501f97

Diff:

Revision 4 (+116 -45)

Show changes

	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/transport/__init__.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/clearcache.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/__init__.py
    rbtools/commands/__init__.py
    rbtools/commands/clearcache.py
    rbtools/api/transport/sync.py
    rbtools/api/cache.py
    rbtools/api/request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/__init__.py
    rbtools/commands/__init__.py
    rbtools/commands/clearcache.py
    rbtools/api/transport/sync.py
    rbtools/api/cache.py
    rbtools/api/request.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.7.x (8e44525)