Hide the archive menu when logged out

Review Request #7286 — Created May 4, 2015 and submitted

Information

Review Board
release-2.5.x
5945ee5...

Reviewers

Previously the unarchive and hide icon was shown to users that were not
logged in. The menu would not appear and clicking on the icon would not
do anything. Now we just hide the UI from users that are not logged in.

No JS errors in browser console.

Manually verified the UI is still shown when logged in.

Description From Last Updated

This should probably be: {% if request.user.is_authenticated and review_request.status == 'P' %}

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/review_detail.html
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/review_detail.html
    
    
  2. 
      
chipx86
  1. 
      
  2. This should probably be:

    {% if request.user.is_authenticated and review_request.status == 'P' %}
    
  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/review_detail.html
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/review_detail.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (bc54952)
Loading...