• 
      

    Restore CMD-click/shift-click/etc. behavior for datagrid rows.

    Review Request #7283 — Created May 2, 2015 and submitted

    Information

    Djblets
    release-0.9.x
    edb0d5d...

    Reviewers

    The recent work to make entire rows clickable in the datagrid preventing
    browser shortcuts for opening in new tabs/windows from working. This was
    because we used an onclick handler, instead of letting the browser do
    all the work.
    
    We now wrap each cell in an <a> instead. If the cell already defined a
    URL, that takes precedence, but it otherwise defaults to the URL of the
    object that row represents.

    Tested keyboard shortcuts and right-click menu on the links. Saw it do the
    right thing in all cases.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          djblets/datagrid/grids.py
      
      Ignored Files:
          djblets/static/djblets/js/datagrid.js
      
      
      
      Tool: Pyflakes
      Processed Files:
          djblets/datagrid/grids.py
      
      Ignored Files:
          djblets/static/djblets/js/datagrid.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.9.x (70c4c3d)