Fix gravatars in review replies and the dashboard.

Review Request #7279 — Created May 1, 2015 and submitted

Information

Review Board
release-2.5.x
57e8437...

Reviewers

The review replies weren't able to make use of gravatars properly, due
to the addition of the gravatars setting check. The variable being used
there wasn't available to the template, so I've plumbed a suitable
variable through.

The datagrid was showing gravatars all the time, not considering that
setting. It now checks before deciding to render the gravatar.

Tested that gravatars appeared in the review replies, and that they were
turned off in both locations when turning off the setting.

Description From Last Updated

Can we pass this in as an argument to generate_reply_html? I know it comes in from the closure, but it's …

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/columns.py
        reviewboard/reviews/templatetags/reviewtags.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_reply.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/columns.py
        reviewboard/reviews/templatetags/reviewtags.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_reply.html
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    Can we pass this in as an argument to generate_reply_html? I know it comes in from the closure, but it's the only thing (other than context) that's done that way--everything else is passed in.

  3. 
      
chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/columns.py
        reviewboard/reviews/templatetags/reviewtags.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_reply.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/columns.py
        reviewboard/reviews/templatetags/reviewtags.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_reply.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (b08eda6)