• 
      

    Add a --disable-ssl-verification flag for use with Python 2.7.9+

    Review Request #7275 — Created May 1, 2015 and submitted

    Information

    RBTools
    release-0.7.x
    f103340...

    Reviewers

    Python now verifies SSL certificates and their associated hostnames by default,
    which is fantastic. However, it makes things a bit of a pain for users who have
    put a self-signed SSL certificate on their Review Board server. This change
    adds a command-line flag and config variable for disabling certificate
    verification.

    • Verified that I got the expected error when running on Python < 2.7.9
    • Set a bogus hostname in my /etc/hosts and tried to post to that server. Saw
      that I got an SSL verification error.
    • Re-ran command with --disable-ssl-verification and saw a login prompt.
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/api/transport/sync.py
          rbtools/api/request.py
          rbtools/utils/commands.py
          rbtools/commands/post.py
          rbtools/commands/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/api/transport/sync.py
          rbtools/api/request.py
          rbtools/utils/commands.py
          rbtools/commands/post.py
          rbtools/commands/__init__.py
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.7.x (295d9c7)