Include the file and interdiff information in diff fragment ETags.

Review Request #7273 — Created May 1, 2015 and submitted

Information

Review Board
release-2.0.x
9009be7...

Reviewers

The diff fragments were only considering diff revision numbers (by way
of the URL) for the ETag, and not the IDs of the objects in the
database. This resulted in stale caches if trying to upload another
draft of a diff with the same revision.

We now include both the filediff ID and the interdiffset ID (if any).

Manually tested, and saw that subsequent uploads of a diff were rendering without
having to clear cache.

Unit tests pass.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/views.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (7fec0e2)