Summary

Increase saturation on indent/deindent markers.

Review Request #7266 — Created April 29, 2015 and submitted April 29, 2015, 2:04 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

291b054...

Reviewers

Groups

reviewboard

People

Description

When indentation has changed, I often completely miss the changes because the
markers were so faint. This change increases the saturation of our chosen
colors from 8% to 20%.

Testing Done

Set the new colors in my browser devtools to check visibility.

Files

Issues

Description	From	Last Updated
I like the red, but the green feels a little harder on the eyes in comparison. Maybe try darkening it …	chipx86	April 29, 2015, 1:46 p.m.
Can you uppercase these?	chipx86	April 29, 2015, 2:04 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/diffviewer.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/diffviewer.less

```
Screenshots?
```

Added Files:

diffviewer colors.png (Revision 1)

The issue has been resolved. Show all issues

I like the red, but the green feels a little harder on the eyes in comparison. Maybe try darkening it just a tad more?

david April 29, 2015, 1:46 p.m.

I'll just darken both. Do you need a new screenshot?

chipx86 April 29, 2015, 1:52 p.m.
```
I'd like one, yeah.
```

Commit:

061a66b25a95aa3d740d6c5076feb9390d8b8c1a

291b054a186ac1df4d5a0a1bdbe6c3f196332ea1

Diff:

Revision 2 (+2 -2)

Show changes

reviewboard/static/rb/css/diffviewer.less

Added Files:

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/diffviewer.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/diffviewer.less

Ship it!

reviewboard/static/rb/css/diffviewer.less (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you uppercase these?
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (04f8ee2)