3857: Problem with displaying java diffs of maven projects in clearcase

der.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
June 1, 2015
What version are you running?
2.0.15

What's the URL of the page containing the problem?
/reviewboard/r/530/diff/

What steps will reproduce the problem?
1. Post diffs of a java maven project inside a clearcase repo
2. Go to server.com/reviewboard/r/530/diff/

What is the expected output? What do you see instead?
Filenames of diff are correct.
"MavenProject/src/main/java/package/Filename.java"
instead the diff file name ends behind src
"MavenProject/src"

For files in the test folder it works "MavenProject/src/test/java/package/FilenameTest.java"


What operating system are you using? What browser?
Win 2008 Server R2


Please provide any additional information below.
Error in ReviewBoard-2.0.15-py2.7.egg\reviewboard\scmtools\clearcase.py
line 53

    # This regular expression can extract from extended_path
    # pure system path. It is construct from two main parts.
    # First match everything from beginning of line to first
    # occurence of /. Second match parts between /main and
    # numbers (file version).
    # This patch assume each branch present in extended_path
    # was derived from /main and there is no file or directory
    # called "main" in path.
    UNEXTENDED = re.compile(r'^(.+?)/|/?(.+?)/main/?.*?/([0-9]+|CHECKEDOUT)')

As mentioned in the comment, this path is not expected to contain a "/main".

For Maven this is recommended!

The regex has to be fixed therefore.
#1 der.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Discussion please here:
https://reviews.reviewboard.org/r/7261/diff/1/
david
#2 david
Is there a reason why you discarded the above-mentioned review request?
  • +NeedInfo
david
#3 david
  • -NeedInfo
    +Incomplete
#4 rishikesh.gupta

I am also facing the same issue .
In java project , "main" directory is not very uncommon .
So the fix describe at https://reviews.reviewboard.org/r/7261/diff/1/ working fine with me.
So how to proceed further to include the fix in reviewboard release ?