Make some of the datagrid classes more generically useful.
Review Request #7260 — Created April 29, 2015 and submitted
The recent dashboard class revamp renamed much of the dashboard-specific
classes to datagrid-specific classes, so we could use them on more
pages. This change goes a step further, taking many of those classes and
making them useful outside of datagrids.There are now a couple of top-level classes for
<body>that define
whether the page has a sidebar or whether the content will be taking up
the full visible height of the page.Some of the datagrid page IDs (
#datagrid_page_containerand
#datagrid_page_content) have been removed, instead making of use of
#page-container,#content_container, and#content. That's two layers of
elements and styles that are removed and made generic.The sidebar classes are also now generic, no longer tied to datagrids.
This will allow us to reuse it for the New Review Request page, and
others.
Tested all the datagrid pages in desktop and mobile modes. Made sure
fit-to-viewport, scrolling, and resizing all worked as expected.Tested the review request, diff viewer, and admin pages.
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/templates/datagrids/datagrid.html reviewboard/templates/base.html reviewboard/templates/datagrids/sidebar_section.html reviewboard/static/rb/css/ui/sidebars.less reviewboard/static/rb/css/pages/base.less reviewboard/static/rb/css/ui/datagrids.less reviewboard/templates/datagrids/sidebar_nav_item.html reviewboard/templates/datagrids/sidebar_user_info.html reviewboard/static/rb/css/defs.less reviewboard/static/rb/js/pages/views/datagridPageView.js Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/templates/datagrids/datagrid.html reviewboard/templates/base.html reviewboard/templates/datagrids/sidebar_section.html reviewboard/static/rb/css/ui/sidebars.less reviewboard/static/rb/css/pages/base.less reviewboard/static/rb/css/ui/datagrids.less reviewboard/templates/datagrids/sidebar_nav_item.html reviewboard/templates/datagrids/sidebar_user_info.html reviewboard/static/rb/css/defs.less reviewboard/static/rb/js/pages/views/datagridPageView.js