• 
      

    Clean up the header of the page, and theme it for specific pages.

    Review Request #7238 — Created April 22, 2015 and submitted

    Information

    Review Board
    release-2.5.x
    e1ea210...

    Reviewers

    In 2.0, the header at the top of the page was separated into the top
    black section with "Review Board," the version, search, and links; and the
    bottom blue section with navigation.
    
    This changes the header to be a single clean entity designed to be a bit
    less noisy, visually, and to fit in better with the given page. The
    colors on the bar are no longer exactly the same across all pages in
    Review Board, but rather are designed to fit in with the color palette
    already on those pages. For instance, on the dashboard or My Account
    pages, it uses a light blue color scheme, while review requests use a
    brown scheme.
    
    Not all pages have been updated for this yet. The administration UI has
    a sort of boring grey for now, for instance. I'll be updating these as I
    continue with the UI redesign.
    
    Note also that the feel of this on the review request page will be
    improving along with the new redesign of that page, coming soon to a
    theater near you.

    Checked all the pages I could think of. Saw a suitable color scheme for the bar.

    I also checked the menus for each page, which had suitable colors as well.


    Description From Last Updated

    Shouldn't this be part of the theme?

    daviddavid
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/templates/base.html
          reviewboard/static/rb/css/pages/newReviewRequest.less
          reviewboard/static/rb/css/mixins/theme.less
          reviewboard/static/rb/css/pages/base.less
          reviewboard/static/rb/css/common.less
          reviewboard/templates/reviews/reviewable_base.html
          reviewboard/static/rb/css/defs.less
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/templates/base.html
          reviewboard/static/rb/css/pages/newReviewRequest.less
          reviewboard/static/rb/css/mixins/theme.less
          reviewboard/static/rb/css/pages/base.less
          reviewboard/static/rb/css/common.less
          reviewboard/templates/reviews/reviewable_base.html
          reviewboard/static/rb/css/defs.less
      
      
    2. 
        
    david
    1. 
        
    2. Show all issues

      Shouldn't this be part of the theme?

      1. It is. It gets overridden later. It's just setting up a default so we have the width and border type. The theme overrides the color.

    3. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (450b1a3)