ReviewBot tool Reek
Review Request #7231 — Created April 21, 2015 and discarded
Reek is a code smell detection for Ruby.It can examine Ruby classes, modules and methods and reports any Code Smells it finds.
It's similar to pep8. So I imitate the file named pep8.py when I writing this document.
This document tries to use the reek as a plugin to detect the file ending with ".rb".
gem install reek
reek [options] [dir_or_source_file]*
| Description | From | Last Updated |
|---|---|---|
|
The first line in this file should be: from __future__ import unicode_literals |
 brennie
|
|
|
Needs a docstring. |
brennie
|
|
|
Col: 80 E501 line too long (83 > 79 characters) |
 reviewbot
|
|
|
No blank line here. |
brennie
|
|
|
Blank line between statement and block. |
brennie
|
|
|
Can we pull this out into a variable (say reek_cmd)? |
brennie
|
|
|
Col: 80 E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
Can you add a comment with example line output of reek ? |
brennie
|
|
|
Col: 1 E112 expected an indented block |
reviewbot
|
|
|
Col: 5 E113 unexpected indentation |
reviewbot
|
|
|
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 16 E131 continuation line unaligned for hanging indent |
reviewbot
|
|
|
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|
|
Col: 2 E122 continuation line missing indentation or outdented |
reviewbot
|
-
This change looks pretty good.
Can you go over this guide for writing change descriptions? Please make sure your description and testing done are complete with respect to that document.
-
-
-
-
-
-
- Change Summary:
-
Change the unreasonable format and the description.
- Description:
-
~ Pick a static analysis tool named Reek and write the plugin.
~ Reek is a code smell detection for Ruby.It can examine Ruby classes, modules and methods and reports any Code Smells it finds.
+ It's similar to pep8. So I imitate the file named pep8.py when I writing this document. + This document tries to use the reek as a plugin to detect the file ending with ".rb". - Testing Done:
-
+ gem install reek
+ reek [options] [dir_or_source_file]* - Commit:
-
27d7962ae397c3882547f426b698377a21630b0697ca6c2e6e6caced32a295f7d20e140b33507af3
- Diff:
-
Revision 2 (+106)
Tool: Pyflakes Processed Files: bot/reviewbot/tools/reek.py Tool: PEP8 Style Checker Processed Files: bot/reviewbot/tools/reek.py