Summary

Improve the styling of the summary state labels in the datagrids.

Review Request #7228 — Created April 17, 2015 and submitted April 23, 2015, 3:32 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

04b6878...

Reviewers

Groups

reviewboard

People

Description

The summary labels ("Draft", "Submitted", "Discarded") were just simple
text prefixes before, which were a bit ugly with the new datagrids, and
didn't do a great job of standing out.

This adds some styling to those to make them appear as little labels.
They're placed to the left of the text block, and each have their own
distinct color.

The summary text retains its own solid block. It no longer wraps below
the label, but instead stays to the right of it. It also has some
additional line spacing, helping to improve readability when it does
wrap.

I also changed the "No Summary" text to be slightly faded out, so that
it doesn't blend in with actual summaries as easily.

Testing Done

Tested the labels at various widths, to ensure the wrapping was correct
an the default state was correct.

Files

Issues

Description	From	Last Updated
'format_html_join' imported but unused	reviewbot	April 17, 2015, 7:57 p.m.
Can we format as: display_data += ('<label class="%s">%s</label>' % labels[label], label)	brennie	April 17, 2015, 7:59 p.m.
Blank line between tehse.	brennie	April 17, 2015, 7:59 p.m.
Can we use <span class="..."> rather than <i>?	david	April 22, 2015, 5:14 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/columns.py

Ignored Files:
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/columns.py

Ignored Files:
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less

reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'format_html_join' imported but unused
```

reviewboard/datagrids/columns.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we format as:

        display_data += ('<label class="%s">%s</label>'
                         % labels[label], label)

reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between tehse.
```

Change Summary:


Removed an unused import.
Added missing blank lines.
Switched to using format_html everywhere in the function.

Commit:

17a7cca12175c2da903f506b27f030221e23f4cb

17291202a265628ac092809870a02bfaaba831ad

Diff:

Revision 2 (+69 -22)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/ui/datagrids.less

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/columns.py

Ignored Files:
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/columns.py

Ignored Files:
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less

reviewboard/datagrids/columns.py (Diff revisions 1 - 2)

Out of curiousity, any reason not to use

display_data += format_html_join('', '<label class={}>{}</label>', (
    (label_class, label)
    for label, label_class in six.iteritems(labels)
))


Wouldn't that be more efficient than multiple concatentations?

reviewboard/datagrids/columns.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we use <span class="..."> rather than <i>?
```

Change Summary:


Switched to using format_html_join.
We now use a <span class="no-summary"> instead of <i>.

Commit:

17291202a265628ac092809870a02bfaaba831ad

04b68784897c5be20fb3e82f32ae4f0f4c7c287c

Diff:

Revision 3 (+71 -21)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/ui/datagrids.less

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/columns.py

Ignored Files:
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/columns.py

Ignored Files:
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (c14d120)