david got a fish trophy!
Keep config separate from app.
Review Request #7227 — Created April 17, 2015 and submitted
The previous implementation loaded all of the config variables into the app
settings table. This was a kind of nice solution because it meant we only had
one object to pass around, but doesn't make it possible to use anything
separate from the webapp. As I add more functionality, I'm planning on adding a
script that can sync user data from the slack API into more local data storage
in a periodic fashion, which won't go through the web stuff.
Loaded the student list and student views and verified that everything still
worked correctly.
Tool: Pyflakes Ignored Files: lib/config.js server.js lib/routes.js lib/reviewboard.js lib/students.js lib/slack.js Tool: PEP8 Style Checker Ignored Files: lib/config.js server.js lib/routes.js lib/reviewboard.js lib/students.js lib/slack.js