Migrate the dashboard-level styles into generic datagrid classes.

Review Request #7223 — Created April 17, 2015 and submitted

Information

Review Board
release-2.5.x
e39e124...

Reviewers

We had a number of styles that were originally specific to the
dashboard, but later became used for other pages (such as the user
page). This included the full-page wrappers, sidebar, etc.

These are useful classes, and pages shouldn't need to pretend to be the
dashboard to get it. Those classes have now been made more generic,
with "dashboad" prefixes replaced with "datagrid."

This is really just code shuffling and renames. Nothing substantial has
changed.

Tested that all the datagrids and their functionality still worked. This
includes all the special functionality of the dashboard (batch selection,
actions, etc.), and column editing/reordering.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/templates/datagrids/datagrid.html
        reviewboard/static/rb/js/dashboard/views/dashboardView.js
        reviewboard/static/rb/css/ie_hacks.css
        reviewboard/templates/datagrids/dashboard.html
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/dashboard.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/templates/datagrids/datagrid.html
        reviewboard/static/rb/js/dashboard/views/dashboardView.js
        reviewboard/static/rb/css/ie_hacks.css
        reviewboard/templates/datagrids/dashboard.html
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/dashboard.less
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (61973ed)